Expose Virtual Host in Route Entry #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lyft/network-team |
mattklein123
reviewed
Jan 5, 2017
| VirtualHostImpl(const Json::Object& virtual_host, Runtime::Loader& runtime, | ||
| Upstream::ClusterManager& cm); | ||
|
|
||
| // Router::VirtualHost |
There was a problem hiding this comment.
nit: interface implementation definitions go below the other random methods.
mattklein123
reviewed
Jan 5, 2017
| public: | ||
| // Router::VirtualHost | ||
| const std::string& name() const override { return name_; } | ||
| std::string name_{"fake_vhost"}; |
There was a problem hiding this comment.
nit: newline before this line
mattklein123
reviewed
Jan 5, 2017
| @@ -18,152 +18,66 @@ namespace Router { | |||
| TEST(BadRateLimitConfiguration, MissingActions) { | |||
| std::string json = R"EOF( | |||
| { | |||
| "virtual_hosts": [ | |||
There was a problem hiding this comment.
You still need some test that tests that the main config properly loads an embedded rate limit. Do you still have at least one test that loads a full config?
There was a problem hiding this comment.
Yes, it is below. The tests are under the RateLimitConfiguration class.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Basic integration test * Addressed comments
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
lizan
pushed a commit
to lizan/envoy
that referenced
this pull request
Nov 25, 2019
Fixes envoyproxy#161. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expose the virtual host that owns the route entry. The virtual host is needed within http/filter/ratelimit.cc to be able to apply ratelimits at the virtual host layer. The next PR will expose RateLimitPolicy on VirtualHost.
This PR also enhances test coverage on RateLimitPolicyEntry and simplifies the test code within router_ratelimit_test.cc