http: keep trailers TE header instead of removing it
#32255
Merged
CI (Envoy) / Envoy/Windows
succeeded
Feb 10, 2024 in 1h 10m 36s
Envoy/Windows (success)
Check has finished
Details
Check run finished (success ✔️)
The check run can be viewed here:
Envoy/Windows (pr/32255/main@71613ec)
Check started by
Request (pr/32255/main@71613ec)
71613ec 
#32255 merge main@da59065
http: set TE header to `trailers` instead of removing it
Official grpc library does not allow empty TE header. This causes an issue when proxying requests through Envoy which currently deletes the TE header since #30535.
I opened a related MR on the grpc library to allow this header to be empty as the HTTP/2 RFC allows it but it might cause issues with other libraries.
Risk Level: medium (behavioral change)
Testing: modified an existing test
Docs Changes: n/a
Release Notes: inline
Platform Specific Features:
Runtime guard: keep the previous one
Environment
Request variables
| Key | Value |
|---|---|
| ref | 2044d5f10cd9436e8c4ef01fb1b135f1b8072340 |
| sha | 71613ec |
| pr | 32255 |
| base-sha | da59065 |
| actor | @quantumsheep |
| message | http: set TE header to trailers instead of removing it... |
| started | 1707527070.814125 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | envoyproxy/envoy-build-ubuntu:0ca52447572ee105a4730da5e76fe47c9c5a7c64 |
| mobile | envoyproxy/envoy-build-ubuntu:mobile-0ca52447572ee105a4730da5e76fe47c9c5a7c64 |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 30 |
| patch | 0 |
| dev | true |
Loading