[ZK filter] Add missing operation supports for multi opcode #32456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhewei Hu <zhewei.hu33@gmail.com>
|
cc @JuniorHsu, please review if you have a chance, thank you! |
JuniorHsu
suggested changes
Feb 26, 2024
Signed-off-by: Zhewei Hu <zhewei.hu33@gmail.com>
Just updated the desc with more details and addressed your comments, PTAL! |
|
/retest |
mattklein123
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: [ZK filter] Add missing operation supports for multi opcode
Additional Description: The ZK filter did not support some operations for the multi opcode based on the ZK source code. This could lead to decode errors. This PR tries to fill this gap by adding the opcode support of
Create2,CreateContainer,CreateTtl,GetChildren, andGetDatafor theMultioperation.Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A