QUIC hot restart part 6 - child instance pauses listening until parent is drained (second try) #32664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning unt… (envoyproxy#32658)" This reverts commit 28ed0f4. Signed-off-by: Raven Black <ravenblack@dropbox.com>
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: QUIC hot restart part 6 - child instance pauses listening until parent is drained (second try)
Additional Description: This is a redo of #31130 which was reverted in #32658. For ease of review, pushed as two commits, the revert that duplicates the original PR, and the small fix with a mutex. (I mistakenly thought the listeners were created on the main thread, but apparently they are created on the worker threads.)
Risk Level: A little, for quic with hot restart.
Testing:
Passes after the fix, fails 5 of 50 with a pointer error before the fix.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a