Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add diagram for histogram stat sink. #32665

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Docs: Add diagram for histogram stat sink. #32665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added source/docs/histogram.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions source/docs/stats.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ followed.
accumulates in to *interval* histograms.
* Finally the main *interval* histogram is merged to *cumulative* histogram.

Pictorially this looks like:

![Histogram Stat Flush](histogram.png)

`ParentHistogram`s are held weakly a set in ThreadLocalStore. Like other stats,
they keep an embedded reference count and are removed from the set and destroyed
when the last strong reference disappears. Consequently, we must hold a lock for
Expand Down
Loading