Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream: desynchronize WRR picks. #3271

Merged
merged 4 commits into from
May 3, 2018
Merged

Commits on May 2, 2018

  1. upstream: desynchronize WRR picks.

    This PR fixes two issues:
    
    * Avoid having synchronized behavior across the fleet by having a seed
      applied to each WRR balancer instance.
    * Avoid having WRR reset to same host on each refresh, biasing towards
      earlier hosts in the schedule.
    
    Risk Level: Medium (there will be observable traffic effects due to
      changes in host pick schedule).
    Testing: New unit tests, modified existing.
    
    Signed-off-by: Harvey Tuch <htuch@google.com>
    htuch committed May 2, 2018
    Configuration menu
    Copy the full SHA
    54d1bb0 View commit details
    Browse the repository at this point in the history
  2. Fix tests.

    Signed-off-by: Harvey Tuch <htuch@google.com>
    htuch committed May 2, 2018
    Configuration menu
    Copy the full SHA
    be96b35 View commit details
    Browse the repository at this point in the history
  3. Comment updates.

    Signed-off-by: Harvey Tuch <htuch@google.com>
    htuch committed May 2, 2018
    Configuration menu
    Copy the full SHA
    1cd1777 View commit details
    Browse the repository at this point in the history
  4. Remove resumption for weighted, it's wrong and complicated to get rig…

    …ht for now.
    
    Signed-off-by: Harvey Tuch <htuch@google.com>
    htuch committed May 2, 2018
    Configuration menu
    Copy the full SHA
    d0fc519 View commit details
    Browse the repository at this point in the history