Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update ipp-crypto to 2021.11.1 #32838

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

zhxie
Copy link
Contributor

@zhxie zhxie commented Mar 12, 2024

Signed-off-by: Xie Zhihao zhihao.xie@intel.com

Commit Message: deps: Update ipp-crypto to 2021.11.1
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #32838 was opened by zhxie.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 12, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @htuch

🐱

Caused by: #32838 was opened by zhxie.

see: more, trace.

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
@zhxie zhxie marked this pull request as ready for review March 13, 2024 02:33
@zhxie zhxie requested a review from soulxu as a code owner March 13, 2024 02:33
@zhxie
Copy link
Contributor Author

zhxie commented Mar 13, 2024

/retest

@zhxie
Copy link
Contributor Author

zhxie commented Mar 13, 2024

The CI shows a curl error about zipkin, I think it is nothing to do with this patch.

@phlax
Copy link
Member

phlax commented Mar 13, 2024

error about zipkin

if you merge main it should be fixed now

@zhxie zhxie marked this pull request as draft March 14, 2024 01:47
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer, thanks!

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Mar 14, 2024
@soulxu
Copy link
Member

soulxu commented Mar 17, 2024

thanks, we removed those temporary patch!

@htuch
Copy link
Member

htuch commented Mar 18, 2024

@zhxie can you mark this as "Ready for review" if you want to merge?

@zhxie zhxie marked this pull request as ready for review March 20, 2024 08:07
@soulxu
Copy link
Member

soulxu commented Mar 20, 2024

/retest

@zhxie
Copy link
Contributor Author

zhxie commented Mar 20, 2024

Thanks all. I just forgot to mark it as ready for review... And now all things are ready.

@soulxu soulxu merged commit e697a93 into envoyproxy:main Mar 20, 2024
54 checks passed
@zhxie zhxie deleted the update-ipp-crypto-2021.11.1 branch March 20, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants