opentelemetrytracer: Dynatrace sampler: Enable adaptative sampling #32848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… API (#21) * Dynatrace sampler to fetch configuration from an API Signed-off-by: Thomas Ebner <96168670+samohte@users.noreply.github.com> Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
…l-config Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
samohte
changed the title
…l-config Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
…l-config Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
wbpcode
reviewed
Mar 17, 2024
source/extensions/tracers/opentelemetry/samplers/dynatrace/sampler_config_provider.cc
Outdated
Show resolved
Hide resolved
source/extensions/tracers/opentelemetry/samplers/dynatrace/sampler_config_provider.cc
Outdated
Show resolved
Hide resolved
|
/lgtm api |
|
/wait |
Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
Thanks for your valuable feedback. I addressed your comments in 535d99b |
wbpcode
reviewed
Mar 19, 2024
source/extensions/tracers/opentelemetry/samplers/dynatrace/sampler_config_provider.cc
Show resolved
Hide resolved
wbpcode
requested changes
Mar 19, 2024
…l-config Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
I have resolved the conflict and answered your comment. Pls. let me know what you think about. |
|
/retest |
wbpcode
approved these changes
Mar 21, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Dynatrace sampler to fetch configuration from an API
Additional Description: In #32598 a custom Dynatrace sampler was added to Envoy. This sampler should now be extended to fetch its configuration via an HTTP call from a Dyantrace cluster.
Testing: Unit, Integration, Manual
Docs Changes: N/A
Release Notes:Dynatrace sampler to fetch configuration from an API
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]