Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Begin process of removing singleton use by StringMatcher (#32… #32902

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

phlax
Copy link
Member

@phlax phlax commented Mar 14, 2024

…829)"

This reverts commit b7818b0.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…oyproxy#32829)"

This reverts commit b7818b0.

Signed-off-by: Ryan Northey <ryan@synca.io>
Copy link

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @alyssawilk

🐱

Caused by: #32902 was opened by phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Mar 14, 2024

@ggreenway this seems to have created a permafailing TIMEOUT in the rbac tests (maybe others)

@phlax
Copy link
Member Author

phlax commented Mar 14, 2024

this is the error:

TIMEOUT: @envoy//test/extensions/filters/http/rbac:rbac_filter_integration_test (Summary)
      /build/bazel_root/base/execroot/envoy_filter_example/bazel-out/k8-fastbuild/testlogs/external/envoy/test/extensions/filters/http/rbac/rbac_filter_integration_test/shard_1_of_2/test.log
INFO: From Testing @envoy//test/extensions/filters/http/rbac:rbac_filter_integration_test (shard 1 of 2):
stdout (/build/bazel_root/base/execroot/envoy_filter_example/bazel-out/_tmp/actions/stdout-25444) 1693776 exceeds maximum size of --experimental_ui_max_stdouterr_bytes=1048576 bytes; skipping
INFO: Elapsed time: 2363.025s, Critical Path: 998.12s
INFO: 19385 processes: 6112 remote cache hit, 8517 internal, 4756 remote.
@envoy//test/extensions/filters/http/rbac:rbac_filter_integration_test  TIMEOUT in 1 out of 2 in 902.3s
  Stats over 2 runs: max = 902.3s, min = 811.2s, avg = 856.8s, dev = 45.5s
  WARNING: @envoy//test/extensions/filters/http/rbac:rbac_filter_integration_test: Test execution time (811.2s excluding execution overhead) outside of range for LONG tests. Consider setting timeout="eternal" or size="enormous".
  /build/bazel_root/base/execroot/envoy_filter_example/bazel-out/k8-fastbuild/testlogs/external/envoy/test/extensions/filters/http/rbac/rbac_filter_integration_test/shard_1_of_2/test.log

Executed 1148 out of 1148 tests: 1147 tests pass and 1 fails remotely.
INFO: Streaming build results to: https://source.cloud.google.com/results/invocations/481c1d87-2517-4e08-bd76-3759c5fa1888
~/envoy-filter-example/bazel-testlogs ~/envoy-filter-example
~/envoy-filter-example

https://dev.azure.com/cncf/envoy/_build/results?buildId=164921&view=logs&j=e969334a-0e55-5c18-ac96-8b546753391e&t=4122df52-7ea9-5745-8c7d-f6b6f2c73149&l=127

@phlax phlax enabled auto-merge (squash) March 14, 2024 12:27
@phlax phlax disabled auto-merge March 14, 2024 13:24
@phlax
Copy link
Member Author

phlax commented Mar 14, 2024

pushing this past windows lag to fix CI

@phlax phlax merged commit 9ac0dd8 into envoyproxy:main Mar 14, 2024
54 checks passed
ggreenway added a commit to ggreenway/envoy that referenced this pull request Mar 14, 2024
…her (envoyproxy#32… (envoyproxy#32902)"

This reverts commit 9ac0dd8.

Signed-off-by: Greg Greenway <ggreenway@apple.com>
phlax pushed a commit that referenced this pull request Mar 14, 2024
* Revert "Revert "Begin process of removing singleton use by StringMatcher (#32… (#32902)"

This reverts commit 9ac0dd8.

Signed-off-by: Greg Greenway <ggreenway@apple.com>

* try increasing shard count to attempt fix of test timeout

Signed-off-by: Greg Greenway <ggreenway@apple.com>

---------

Signed-off-by: Greg Greenway <ggreenway@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants