Skip to content

mobile: cleaning up CI options #33007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2024
Merged

mobile: cleaning up CI options #33007

merged 2 commits into from
Mar 21, 2024

Conversation

alyssawilk
Copy link
Contributor

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #33007 was opened by alyssawilk.

see: more, trace.

@alyssawilk
Copy link
Contributor Author

Hm, I would have expected this to kick off mobile CI. @phlax is this expected to you? if not hoping #33011 will fix

@phlax
Copy link
Member

phlax commented Mar 20, 2024

Hm, I would have expected this to kick off mobile CI

yeah, the matcher is mobile/**/* which i would have thought would catch but seemingly it doesnt - i think your PR will fix - its on my todo to debug the glob matcher to figure out why that doesnt work

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Contributor Author

probably one of those annoying "ignore . files by default" things :-/

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Contributor Author

/retest

@alyssawilk alyssawilk marked this pull request as ready for review March 21, 2024 18:27
@alyssawilk alyssawilk enabled auto-merge (squash) March 21, 2024 18:27
@alyssawilk alyssawilk merged commit d298fdc into envoyproxy:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants