[http-cache] Don't bypass the cache for if-unmodified-since or if-match #33080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
toddmgreer
approved these changes
Mar 28, 2024
ravenblackx
changed the title
|
+ggreenway for senior stamp |
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
…ch (envoyproxy#33080) * [cache] Don't bypass the cache for if-unmodified-since or if-match --------- Signed-off-by: Raven Black <ravenblack@dropbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: [http-cache] Don't bypass the cache for if-unmodified-since or if-match
Additional Description: There's a whole section of the cache filter to do with conditional headers that's unimplemented ("if needed, implement it to this spec!"). Turns out we only need the very easy to implement subset, where the cache is supposed to ignore one of the conditional headers. I threw in the other one that's supposed to be ignored as well.
Risk Level: Very low, it's a WIP filter and an edge case use of it where before the change it does the wrong thing.
Testing: Doesn't even make sense to have a special test for this - there are an infinite number of headers the cache should ignore.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a