use StopAllIterationAndWatermark in geoip filter #33122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hwyuan, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
ravenblackx
previously approved these changes
Mar 26, 2024
ravenblackx
reviewed
Mar 26, 2024
|
Thank you for neat contribution, PR lgtm modulo ci and changelog needs to be updated. |
Signed-off-by: Haowei Yuan <hyuan@wustl.edu>
hwyuan
force-pushed
the
geoip-stop-all-iteration-and-watermark
branch
from
d215a4c
to
fd50b89
Compare
nezdolik
approved these changes
Mar 27, 2024
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: use StopAllIterationAndWatermark in geoip filter
Additional Description:
Use
StopAllIterationAndWatermarkin geoip filter to stop both headers and data when performing async geoip lookup. This fixes the issue in #33021 where large POST request data got corrupted.Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Fixes #33021
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]