golang filter: do not clear route cache in ·HeaderMap.Set` by default. #33229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduce a new API `ClearRouteCache` to clear route cache. fix envoyproxy#33082 Signed-off-by: doujiang24 <doujiang24@gmail.com>
|
/assign @wangfakang @spacewander |
|
@spacewander cannot be assigned to this issue. |
|
@doujiang24 I CCed few owner, but let me know if you think this is ready to merge, I can help to merge since this is contrib ext. |
|
Thanks, @soulxu , let's wait an approval from from @wangfakang @spacewander . |
spacewander
approved these changes
Apr 1, 2024
wangfakang
reviewed
Apr 1, 2024
Signed-off-by: doujiang24 <doujiang24@gmail.com>
Signed-off-by: doujiang24 <doujiang24@gmail.com>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
envoyproxy#33229) * golang filter: do not clear route cache in HeaderMap.Set by default. introduce a new API `ClearRouteCache` to clear route cache. fix envoyproxy#33082 Signed-off-by: doujiang24 <doujiang24@gmail.com>
spacewander
pushed a commit
to mosn/envoy
that referenced
this pull request
Jun 27, 2024
envoyproxy#33229) * golang filter: do not clear route cache in HeaderMap.Set by default. introduce a new API `ClearRouteCache` to clear route cache. fix envoyproxy#33082 Signed-off-by: doujiang24 <doujiang24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce a new API
ClearRouteCacheto clear route cache.fix #33082
Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]