Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mobile: Bump swift-async-await test timeout #33455

Merged
merged 1 commit into from
Apr 10, 2024
Merged

mobile: Bump swift-async-await test timeout #33455

merged 1 commit into from
Apr 10, 2024

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented Apr 10, 2024 •
edited
Loading

This should hopefully fix the flakiness issue, such as https://github.com/envoyproxy/envoy/actions/runs/8636677357/job/23677319014

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

@fredyw
Bump iOS test timeout
e0396b9 
Signed-off-by: Fredy Wijaya <fredyw@google.com>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #33455 was opened by fredyw.

see: more, trace.

@fredyw fredyw changed the title Bump iOS test timeout mmobile: Bump swift-async-await test timeout Apr 10, 2024
@fredyw fredyw marked this pull request as ready for review April 10, 2024 21:17
@fredyw
Copy link
Member Author

fredyw commented Apr 10, 2024

/assign @phlax

@fredyw fredyw enabled auto-merge (squash) April 10, 2024 21:17
phlax
phlax approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @fredyw

@fredyw fredyw changed the title mmobile: Bump swift-async-await test timeout mobile: Bump swift-async-await test timeout Apr 10, 2024
@fredyw
Copy link
Member Author

fredyw commented Apr 10, 2024

/retest

1 similar comment
@fredyw
Copy link
Member Author

fredyw commented Apr 10, 2024

/retest

@fredyw fredyw merged commit 5b9ac6f into envoyproxy:main Apr 10, 2024
50 of 51 checks passed
@fredyw fredyw deleted the bump_ios_test_timeout branch April 10, 2024 22:51
alyssawilk pushed a commit to alyssawilk/envoy that referenced this pull request Apr 29, 2024
@fredyw @alyssawilk
mmobile: Bump swift-async-await test timeout (envoyproxy#33455)
32d5a1f 
This should hopefully fix the flakiness issue, such as https://github.com/envoyproxy/envoy/actions/runs/8636677357/job/23677319014

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Fredy Wijaya <fredyw@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlax phlax phlax approved these changes

Assignees

@phlax phlax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredyw @phlax