proxy_protocol_filter: Add field stat_prefix to the filter configuration
#34414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teju Nareddy <tnareddy@confluent.io>
Signed-off-by: Teju Nareddy <tnareddy@confluent.io>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
@ggreenway I believe you have the most context based on #32861 (comment). Sorry for the late follow-up! |
Signed-off-by: Teju Nareddy <tnareddy@confluent.io>
|
PTAL @jmarantz |
|
PTAL, would like to get this merged soon. |
|
@jmarantz this should be a quick review :) |
jmarantz
previously approved these changes
Jun 5, 2024
docs/root/configuration/listeners/listener_filters/proxy_protocol.rst
Outdated
Show resolved
Hide resolved
|
one documentation nit remains. |
Done, PTAL |
|
Looks like fuzz coverage is broken, seems unrelated to my PR |
|
/retest |
|
PTAL, CI passed @jmarantz @ggreenway |
|
PTAL @jmarantz |
jmarantz
approved these changes
Jun 8, 2024
nareddyt
added a commit
to nareddyt/envoy
that referenced
this pull request
Jun 10, 2024
…ation (envoyproxy#34414) Commit Message: proxy_protocol_filter: Add field stat_prefix to the filter configuration Additional Description: This field allows for differentiating statistics when multiple proxy protocol listener filters are configured. This PR is a follow-up from previous conversation: envoyproxy#32861 (comment) Risk Level: Low All client-facing behavior changes are guarded by new filter config field. Testing: Stats unit tests Proxy protocol listener filter integration tests Docs Changes: Done Release Notes: Done Platform Specific Features: None Signed-off-by: Teju Nareddy <tnareddy@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
proxy_protocol_filter: Add field
stat_prefixto the filter configurationAdditional Description:
This field allows for differentiating statistics when multiple proxy protocol listener filters are configured.
This PR is a follow-up from previous conversation: #32861 (comment)
Risk Level: Low
Testing:
Docs Changes:
Done
Release Notes:
Done
Platform Specific Features:
None