Add big endian support to the dns parser #34456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: //test/extensions/filters/udp/dns_filter:dns_filter_integration_test //test/extensions/filters/udp/dns_filter:dns_filter_test on big endian platforms. Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
|
Hi @jonathan-albrecht-ibm, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
Assigning Matt as codeowner Can you please fix format (see CI error). |
Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
|
Thanks @adisuissa, it was a spelling mistake in a comment |
mattklein123
approved these changes
Jun 8, 2024
|
Thanks for reviewing and merging @mattklein123! |
mattklein123
pushed a commit
that referenced
this pull request
Dec 11, 2024
<!-- !!!ATTENTION!!! If you are fixing *any* crash or *any* potential security issue, *do not* open a pull request in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately. Thank you in advance for helping to keep Envoy secure. !!!ATTENTION!!! For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md) --> Commit Message: Additional Description: I believe it is stable now since we conduct a security review and improvement for dns filter like #18651 #20744 #22861 #17479 #34409 #34456 #34490 and so on Risk Level: low Testing: Docs Changes: Release Notes: Signed-off-by: Boteng Yao <boteng@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
//test/extensions/filters/udp/dns_filter:dns_filter_integration_test //test/extensions/filters/udp/dns_filter:dns_filter_test on big endian platforms.
Commit Message:
Additional Description: These changes fix the serialization of 128 bit ip address values on big endian platforms and adds a big endian definition of the dns header struct with the fields ordered so that they can be serialized easily on big endian platforms.
One test is skipped on s390x builds due to a known issue with the undetermined ordering of some of the test values that happens reliably on s390x.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]