optimeize unescape slash path #34934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chenylh <chenyuliang@jd.com>
|
Hi @chenylh, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Signed-off-by: chenyuliang5 <chenyuliang@jd.com>
Signed-off-by: chenyuliang5 <chenyuliang@jd.com>
Signed-off-by: chenyuliang5 <chenyuliang@jd.com>
Signed-off-by: chenyuliang5 <chenyuliang@jd.com>
|
Seems fine but is this actually faster? /wait |
Signed-off-by: chenyuliang5 <chenyuliang@jd.com>
|
@yanavlasov friendly ping |
yanavlasov
requested changes
Jul 9, 2024
source/common/http/path_utility.cc
Outdated
| unescapeInPath(decoded_path, "%5C", "\\"); | ||
| unescapeInPath(decoded_path, "%5c", "\\"); | ||
| headers.setPath(absl::StrCat(decoded_path, query)); | ||
| std::map<const char*, const char*> replacements; |
There was a problem hiding this comment.
Suggested change
| std::map<const char*, const char*> replacements; | |
| static const std::vector<std::pair<absl::string_view, absl::string_view>> replacements{{"2F", "/"}, {"2f", "/"}, ...}; |
And then remove dynamic initialization below.
Signed-off-by: chenyuliang5 <chenyuliang@jd.com>
Signed-off-by: chenyuliang5 <chenyuliang@jd.com>
yanavlasov
requested changes
Jul 10, 2024
Signed-off-by: chenyuliang5 <chenyuliang@jd.com>
yanavlasov
approved these changes
Aug 1, 2024
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
--------- Signed-off-by: chenylh <chenyuliang@jd.com> Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
--------- Signed-off-by: chenylh <chenyuliang@jd.com> Signed-off-by: asingh-g <abhisinghx@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]