router: add API to retry reset before request #35074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When proxying to upstreams that may be performing non-idempotent operations, it may be desirable to only retry connection rests when the upstream has not yet seen the request. We add the reset-before-request option to provide this functionality. Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
keithmattix
changed the title
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
alyssawilk
reviewed
Jul 8, 2024
Instead of using a bool + callback approach in the router, when the reset-before-request retry policy is set, we check the upstream timings to see if the first upstream byte has been transferred. Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Thanks for the feedback! Release notes are added and refactoring is complete |
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
alyssawilk
reviewed
Jul 9, 2024
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
|
/retest |
wbpcode
reviewed
Jul 11, 2024
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
wbpcode
approved these changes
Jul 12, 2024
keithmattix
added a commit
to istio/community
that referenced
this pull request
Jul 18, 2024
Istio has very few maintainers here and though I'm still learning, I've contributed a handful of upstream envoy PRs as well as 2 recent changes to istio-proxy's telemetry. If existing maintainers have other areas they'd like to see more contributions in, I welcome the feedback! PRs: - envoyproxy/envoy#35074 - envoyproxy/envoy#33857 - envoyproxy/envoy#33362 - envoyproxy/envoy#32961 - istio/proxy#5617 - istio/proxy#5514
istio-testing
pushed a commit
to istio/community
that referenced
this pull request
Jul 19, 2024
Istio has very few maintainers here and though I'm still learning, I've contributed a handful of upstream envoy PRs as well as 2 recent changes to istio-proxy's telemetry. If existing maintainers have other areas they'd like to see more contributions in, I welcome the feedback! PRs: - envoyproxy/envoy#35074 - envoyproxy/envoy#33857 - envoyproxy/envoy#33362 - envoyproxy/envoy#32961 - istio/proxy#5617 - istio/proxy#5514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10007
Commit Message: Add new reset-before-request retry API that will only retry reset connections if the headers haven't been delivered.
Additional Description:
Risk Level: Low
Testing: Unit and e2e
Docs Changes: Add new reset-before-request
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]