server: fixed crash in server properties cache #35268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
|
@botengyao Fix for the crash I reported to envoy-security group. |
KBaichoo
approved these changes
Jul 19, 2024
|
Thanks @cpakulski and @KBaichoo! |
|
Thanks for reviewing @KBaichoo ! |
|
Marked it for backport. I can do the actual work. |
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
fix for crash in server properties cache
Additional Description:
Reported the crash to envoy-security@googlegroups.com and got green light to proceed in public. The issue is that key_value_store_ used in cache may be NULL, so it should be checked before each use.
Risk Level: Low
Testing: Converted to parameterized tests to run each test with valid and NULL key_value_store_.
Docs Changes: No
Release Notes: No