Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding http client support for ext_proc filter #35676

Merged
merged 16 commits into from
Aug 17, 2024

Conversation

yanjunxiang-google
Copy link
Contributor

@yanjunxiang-google yanjunxiang-google commented Aug 12, 2024

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes:

Description:
This is to address the 2st step of #35488, i.e, the ext_proc HTTP client framework.

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
…roc_http_client

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
@yanjunxiang-google yanjunxiang-google marked this pull request as ready for review August 14, 2024 21:05
@adisuissa
Copy link
Contributor

/assign @tyxia

@yanjunxiang-google
Copy link
Contributor Author

yanjunxiang-google commented Aug 15, 2024

@tyxia FYI: this PR is just to lay down the foundation of the file structure of http client. There will be follow up changes to integrate the http client with the ext_proc filter code. The idea is to add incremental small changes as outlined in #35488.

@yanjunxiang-google
Copy link
Contributor Author

/assign @htuch @yanavlasov @rshriram

tyxia
tyxia previously approved these changes Aug 16, 2024
Copy link
Member

@tyxia tyxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a skeleton to start.

Thanks!

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
@tyxia tyxia enabled auto-merge (squash) August 17, 2024 14:27
…roc_http_client

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
@tyxia tyxia merged commit dbb35fa into envoyproxy:main Aug 17, 2024
47 checks passed
@yanjunxiang-google yanjunxiang-google deleted the ext_proc_http_client branch August 18, 2024 13:59
yanavlasov pushed a commit that referenced this pull request Sep 30, 2024
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes:

Description:
This is to address the issue:
#35488, i.e, integrate the
ext_proc HTTP client to ext_proc filter. With this PR, the basic
functionalities to have Envoy ext_proc filter talk to a HTTP server
using HTTP messages are accomplished.

This is the follow up of PR:
#35676

---------

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
update-envoy bot added a commit to envoyproxy/data-plane-api that referenced this pull request Sep 30, 2024
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes:

Description:
This is to address the issue:
envoyproxy/envoy#35488, i.e, integrate the
ext_proc HTTP client to ext_proc filter. With this PR, the basic
functionalities to have Envoy ext_proc filter talk to a HTTP server
using HTTP messages are accomplished.

This is the follow up of PR:
envoyproxy/envoy#35676

---------

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

Mirrored from https://github.com/envoyproxy/envoy @ a3e32c92c5ae699a4daad094c6a87b58e1e84ec2
duxin40 pushed a commit to duxin40/envoy that referenced this pull request Oct 15, 2024
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes:

Description:
This is to address the 2st step of
envoyproxy#35488, i.e, the ext_proc HTTP
client framework.

---------

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: duxin40 <duxin40@gamil.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants