tls-tests: updating the auto-generated certs for TLS tests #35781
+2,553
−2,478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
jmarantz
approved these changes
Aug 21, 2024
|
@adisuissa there is a ticket to address the committed certs here #23912 i just didnt get round to looking at it yet i think this needs ... /backport |
repokitteh-read-only
bot
added
the
backport/review
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 22, 2024
…y#35781) Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Adi (Suissa) Peleg <adip@google.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 22, 2024
…y#35781) Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Adi (Suissa) Peleg <adip@google.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 22, 2024
…y#35781) Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Adi (Suissa) Peleg <adip@google.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 22, 2024
…y#35781) Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Adi (Suissa) Peleg <adip@google.com>
phlax
pushed a commit
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Adi (Suissa) Peleg <adip@google.com>
phlax
pushed a commit
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Adi (Suissa) Peleg <adip@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 22, 2024
…y#35781) Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Adi (Suissa) Peleg <adip@google.com>
Yep... it needs to be backported. |
|
i backported it already as it was failing branch ci - not 100% if i did it correctly but it seems to have worked on all but 1.28 fwiw only 1.30 and 1.31 were actually failing so not clear whether it was needed on 1.28 (or 1.29) |
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 28, 2024
…y#35781) Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 28, 2024
…y#35781) Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 28, 2024
…y#35781) Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 28, 2024
…y#35781) Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 28, 2024
…y#35781) Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 28, 2024
…y#35781) Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Adi (Suissa) Peleg <adip@google.com>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 28, 2024
…y#35781) Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 28, 2024
…y#35781) Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: tls-tests: updating the auto-generated certs for TLS tests
Additional Description:
Some tests are broken due to out of date. Previous refresh was in #22792.
Most changes were the output of
test/common/tls/test_data/certs.sh.3 non-automatic modifications:
test/common/tls/test_data/certs.sh- updated because openssl x509 days argument no longer accepts days that are < -1.test/common/tls/ssl_socket_test.cc- introduced new fields that are not automatically generated. Fixed the tests tofetch the info from the source of truth.
test/extensions/transport_sockets/tls/cert_validator/spiffe/spiffe_validator_test.cc- a test has exact expectations on the dates in the certificates.Need to think about Matt's comment and see if we can avoid checking in the certs.
Risk Level: low - tests only
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Fixes #35780