Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky geoip test #35862

Merged
merged 2 commits into from
Aug 27, 2024

Clean up

a03ff40
Select commit
Loading
Failed to load commit list.
Merged

Fix flaky geoip test #35862

Clean up
a03ff40
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Release validation skipped Aug 27, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/35862/main@a03ff40)

nezdolik @nezdolik a03ff40 #35862 merge main@1175a4f

Fix flaky geoip test

On some runs mmdb_reload custom thread is not starting until tests ends which results in segfaults in the test. Addding cond var to await in the test for when mmdb reload thread has populated the callbacks.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Fixes #35829
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Environment

Request variables

Key Value
ref 839101a
sha a03ff40
pr 35862
base-sha 1175a4f
actor nezdolik @nezdolik
message Fix flaky geoip test...
started 1724764052.087171
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true