Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPORTANT/bp/1.28] Multiple CVEs #36222

Closed
wants to merge 3 commits into from
Closed

[IMPORTANT/bp/1.28] Multiple CVEs #36222

wants to merge 3 commits into from

Conversation

phlax
Copy link
Member

@phlax phlax commented Sep 19, 2024

CVE-2024-45808: Malicious log injection via access logs
CVE-2024-45806: Potential manipulate x-envoy headers from external sources
CVE-2024-45810: Envoy crashes for LocalReply in http async client

alyssawilk and others added 3 commits September 19, 2024 16:03
@alyssawilk @phlax
internal_address_config: change the default to be more secure for ser…
5ed4013 
…vice mesh environments

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@botengyao @phlax
fix local reply in async client and destroy order
ade9849 
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@tyxia @phlax
escape invalid host name
c2c6152 
Signed-off-by: tyxia <tyxia@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #36222 was opened by phlax.

see: more, trace.

@phlax phlax assigned botengyao and unassigned markdroth Sep 19, 2024
@markdroth
Copy link
Contributor

/lgtm api

botengyao
botengyao approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@botengyao botengyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks @phlax!

adisuissa
adisuissa approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phlax
Copy link
Member Author

phlax commented Sep 19, 2024

closing this one in favour of #36213 - to get the release cycling more quickly

the rest ill land separately

@phlax phlax closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisuissa adisuissa adisuissa approved these changes

@botengyao botengyao botengyao approved these changes

@tyxia tyxia Awaiting requested review from tyxia tyxia is a code owner

@ggreenway ggreenway Awaiting requested review from ggreenway ggreenway is a code owner

@alyssawilk alyssawilk Awaiting requested review from alyssawilk alyssawilk is a code owner

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

Assignees

@botengyao botengyao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@phlax @markdroth @adisuissa @botengyao @alyssawilk @tyxia