Skip to content

Conversation

@keithmattix
Copy link
Contributor

Here's as far as I got; there's a linking error I'm running into that is past the extent of my bazel knowledge

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 29, 2024
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #36880 was opened by keithmattix.

see: more, trace.

@RyanTheOptimist
Copy link
Contributor

RyanTheOptimist commented Oct 29, 2024

I don't think I understand the PR description, which talks about a linker error?

@RyanTheOptimist
Copy link
Contributor

/wait

@phlax
Copy link
Member

phlax commented Oct 29, 2024

@RyanTheOptimist this is a PR against a PR im working on (#36857)

the linker issue can be seen here https://github.com/envoyproxy/envoy/actions/runs/11565055505/job/32191460743#step:13:4041

@RyanTheOptimist
Copy link
Contributor

@RyanTheOptimist this is a PR against a PR im working on (#36857)

the linker issue can be seen here https://github.com/envoyproxy/envoy/actions/runs/11565055505/job/32191460743#step:13:4041

Sounds good. Swapped you in as the reviewer

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 28, 2024
@phlax phlax removed the stale stalebot believes this issue/PR has not been touched recently label Nov 28, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 29, 2024
@keithmattix
Copy link
Contributor Author

Did you ever get this working @phlax?

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Dec 30, 2024
@phlax
Copy link
Member

phlax commented Dec 30, 2024

not so far, but a bunch of stuff has been updated since so probably worth another try

phlax added a commit that referenced this pull request Jan 7, 2025
…`wamr` -> 2.2.0 (#37868)

Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0,
`wasmtime` -> 24.0.2, `wamr` -> 2.2.0
Additional Description:
proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing: `bazel test test/...` passes, with `--define=wasm=v8`,
`--define=wasm=wamr`, and `--define=wasm=wasmtime`.
Docs Changes: None.
Release Notes: Mentioned new support for [Go
SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins.

Supercedes #36880 and #36857

---------

Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Keith Mattix II <keithmattix@microsoft.com>
@keithmattix keithmattix closed this Jan 9, 2025
Yueren-Wang pushed a commit to Yueren-Wang/envoy that referenced this pull request Jan 9, 2025
…`wamr` -> 2.2.0 (envoyproxy#37868)

Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0,
`wasmtime` -> 24.0.2, `wamr` -> 2.2.0
Additional Description:
proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing: `bazel test test/...` passes, with `--define=wasm=v8`,
`--define=wasm=wamr`, and `--define=wasm=wasmtime`.
Docs Changes: None.
Release Notes: Mentioned new support for [Go
SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins.

Supercedes envoyproxy#36880 and envoyproxy#36857

---------

Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Yueren Wang <yuerenwang@lyft.com>
phlax added a commit to phlax/envoy that referenced this pull request Oct 9, 2025
…`wamr` -> 2.2.0 (envoyproxy#37868)

Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0,
`wasmtime` -> 24.0.2, `wamr` -> 2.2.0
Additional Description:
proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing: `bazel test test/...` passes, with `--define=wasm=v8`,
`--define=wasm=wamr`, and `--define=wasm=wasmtime`.
Docs Changes: None.
Release Notes: Mentioned new support for [Go
SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins.

Supercedes envoyproxy#36880 and envoyproxy#36857

---------

Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Keith Mattix II <keithmattix@microsoft.com>
phlax added a commit to phlax/envoy that referenced this pull request Oct 9, 2025
…`wamr` -> 2.2.0 (envoyproxy#37868)

Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0,
`wasmtime` -> 24.0.2, `wamr` -> 2.2.0
Additional Description:
proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing: `bazel test test/...` passes, with `--define=wasm=v8`,
`--define=wasm=wamr`, and `--define=wasm=wasmtime`.
Docs Changes: None.
Release Notes: Mentioned new support for [Go
SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins.

Supercedes envoyproxy#36880 and envoyproxy#36857

---------

Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Keith Mattix II <keithmattix@microsoft.com>
phlax added a commit to phlax/envoy that referenced this pull request Oct 9, 2025
…`wamr` -> 2.2.0 (envoyproxy#37868)

Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0,
`wasmtime` -> 24.0.2, `wamr` -> 2.2.0
Additional Description:
proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing: `bazel test test/...` passes, with `--define=wasm=v8`,
`--define=wasm=wamr`, and `--define=wasm=wasmtime`.
Docs Changes: None.
Release Notes: Mentioned new support for [Go
SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins.

Supercedes envoyproxy#36880 and envoyproxy#36857

---------

Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Keith Mattix II <keithmattix@microsoft.com>
phlax added a commit to phlax/envoy that referenced this pull request Oct 9, 2025
…`wamr` -> 2.2.0 (envoyproxy#37868)

Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0,
`wasmtime` -> 24.0.2, `wamr` -> 2.2.0
Additional Description:
proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing: `bazel test test/...` passes, with `--define=wasm=v8`,
`--define=wasm=wamr`, and `--define=wasm=wasmtime`.
Docs Changes: None.
Release Notes: Mentioned new support for [Go
SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins.

Supercedes envoyproxy#36880 and envoyproxy#36857

---------

Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Oct 9, 2025
…`wamr` -> 2.2.0 (envoyproxy#37868)

Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0,
`wasmtime` -> 24.0.2, `wamr` -> 2.2.0
Additional Description:
proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing: `bazel test test/...` passes, with `--define=wasm=v8`,
`--define=wasm=wamr`, and `--define=wasm=wasmtime`.
Docs Changes: None.
Release Notes: Mentioned new support for [Go
SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins.

Supercedes envoyproxy#36880 and envoyproxy#36857

---------

Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Oct 10, 2025
…`wamr` -> 2.2.0 (envoyproxy#37868)

Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0,
`wasmtime` -> 24.0.2, `wamr` -> 2.2.0
Additional Description:
proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing: `bazel test test/...` passes, with `--define=wasm=v8`,
`--define=wasm=wamr`, and `--define=wasm=wasmtime`.
Docs Changes: None.
Release Notes: Mentioned new support for [Go
SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins.

Supercedes envoyproxy#36880 and envoyproxy#36857

---------

Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit that referenced this pull request Oct 10, 2025
…`wamr` -> 2.2.0 (#37868)

Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0,
`wasmtime` -> 24.0.2, `wamr` -> 2.2.0
Additional Description:
proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing: `bazel test test/...` passes, with `--define=wasm=v8`,
`--define=wasm=wamr`, and `--define=wasm=wasmtime`.
Docs Changes: None.
Release Notes: Mentioned new support for [Go
SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins.

Supercedes #36880 and #36857

---------

Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants