stats: Sink CounterImpl and GaugeImpl into stats_impl.cc; no need to have them in the .h #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em in the .h Also simplifies the prometheus tests in admin_test.cc for readability, which seemed natural to me as I removed the references to CounterImpl and GaugeImpl. Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
commented
Jun 22, 2018
| @@ -175,6 +175,70 @@ RawStatData* HeapRawStatDataAllocator::alloc(const std::string& name) { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
note: this is a simple cut&paste from stats_impl.h.
|
Please merge master and check test failures (probably master was broken). |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
|
done; thanks |
mattklein123
approved these changes
Jun 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Risk Level: Low
Testing: //test/...
Docs Changes: N/A
Release Notes: N/A