authz_fix: keep the previous behaviour of adding encoding header #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel <gsagula@gmail.com>
|
@mccv @mattklein123 I found that the previous bug fix changed the original behaviour of the filter. I open this PR to bring it back. Please feel free to take a look whenever you have a chance and let me know if it doesn't make sense. Thanks! |
|
@gsagula can you add a test for this behavior? |
|
@htuch For sure. I'll be on the road for the most of the day, but I can try to do that a bit later this evening or tomorrow. Thanks! |
Signed-off-by: Gabriel <gsagula@gmail.com>
|
@htuch I've added the test. Please let me know if there is anything else that I should change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gabriel gsagula@gmail.com
Description: This PR brings back the previous behaviour of adding/modifying the encoding headers. Before #3759, headers sent from the authorization server to the downstream client needed to be added via
setReferenceKey()method which behaves differently than the current implementation which usesaddCopy(). To mimic the previous behaviour, the header needs to be removed before adding the new one.Risk Level: low
Testing: unit and manual testing