api: remove support for cluster_names field in ApiConfigSource protos of type gRPC #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype gRPC. Signed-off-by: James Buckland <jbuckland@google.com>
htuch
suggested changes
Jul 9, 2018
source/common/config/utility.cc
Outdated
| @@ -90,12 +94,8 @@ void Utility::checkApiConfigSourceNames( | |||
|
|
|||
| if (is_grpc) { | |||
| if (api_config_source.cluster_names().size() != 0) { | |||
There was a problem hiding this comment.
Nit: !api_config_source.cluster_names().empty().
Signed-off-by: James Buckland <jbuckland@google.com>
htuch
previously approved these changes
Jul 9, 2018
Signed-off-by: James Buckland <jbuckland@google.com>
mattklein123
approved these changes
Jul 9, 2018
|
Hello guys, do you have some plan to update the documentation? The dynamic_resources:
lds_config:
api_config_source:
api_type: GRPC
cluster_names: [xds_cluster]
cds_config:
api_config_source:
api_type: GRPC
cluster_names: [xds_cluster]dynamic_resources:
lds_config:
api_config_source:
api_type: GRPC
cds_config:
api_config_source:
api_type: GRPC |
|
@ambuc ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Buckland jbuckland@google.com
Description:
As noted in #3716, we want to deprecate support for the cluster_names field in ApiConfigSource protos (
api/envoy/api/v2/core/config_source.proto) of type gRPC. This change only effects configs of type gRPC; configs of type REST and REST_LEGACY are unchanged. This change had its groundwork laid in issue #2860 and PR #3067.Risk Level: Medium. This will throw an EnvoyException on nonconforming configs. This change is part of the 1.8.0 milestone.
Testing:
//test/common/config/utility_test.cchad to be changed to account for this.Docs Changes: I don't think
docs/root/configuration/overview/v2_overview.rstneeds to be changed for this.Fixes #3716