api: added csharp namespace override to cluster and listener packages #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes envoyproxy#3827 Signed-off-by: skwasiborski <skwa@demant-technology.com>
htuch
approved these changes
Jul 13, 2018
kavyako
pushed a commit
to microsoft/envoy
that referenced
this pull request
Nov 13, 2018
…envoyproxy#3854) Fixes envoyproxy#3827 Signed-off-by: skwasiborski <skwa@demant-technology.com>
jstallard
added a commit
to jstallard/envoy
that referenced
this pull request
Jun 22, 2019
This fixes for ruby what envoyproxy#3854 fixed for C#.
jstallard
added a commit
to jstallard/envoy
that referenced
this pull request
Jun 22, 2019
This fixes for ruby what envoyproxy#3854 fixed for C#. Description: The existing protos yield a ruby module and class with the same name for both cluster and listener. This fixes for ruby what envoyproxy#3854 fixed for C#. Risk Level: Low Testing: I successfully generated valid envoy configurations using the ruby code generated by these updated protos. Docs Changes: N/A Release Notes: Ruby module name overrides for data plane api proto definitions. Signed-off-by: Justin Stallard <jstallard@gmail.com>
mattklein123
pushed a commit
that referenced
this pull request
Jun 22, 2019
This fixes for ruby what #3854 fixed for C#. Description: The existing protos yield a ruby module and class with the same name for both cluster and listener. This fixes for ruby what #3854 fixed for C#. Risk Level: Low Testing: I successfully generated valid envoy configurations using the ruby code generated by these updated protos. Docs Changes: N/A Release Notes: Ruby module name overrides for data plane api proto definitions. Signed-off-by: Justin Stallard <jstallard@gmail.com>
mattklein123
pushed a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Jun 22, 2019
This fixes for ruby what envoyproxy/envoy#3854 fixed for C#. Description: The existing protos yield a ruby module and class with the same name for both cluster and listener. This fixes for ruby what envoyproxy/envoy#3854 fixed for C#. Risk Level: Low Testing: I successfully generated valid envoy configurations using the ruby code generated by these updated protos. Docs Changes: N/A Release Notes: Ruby module name overrides for data plane api proto definitions. Signed-off-by: Justin Stallard <jstallard@gmail.com> Mirrored from https://github.com/envoyproxy/envoy @ 47925a53e67645fa20ca60a5c3257084bd870994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Api definitions for data plane api contain messages that cause naming conflict when used by protoc to build c# classes. There are two instances of the problem:
The same problem occurs with package: envoy.api.v2 message: listener and package: envoy.api.v2.listener. Added namespace definition as Envoy.Api.V2.ListenerNS.
Risk Level: Low
Testing: None (there is currently no testing done for csharp)
Docs Changes: None
Release Notes: CSharp namespace overrides for data plane api proto definitions.
Fixes: #3827
Signed-off-by: skwasiborski skwa@demant-technology.com