Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health check: Remove the deprecated redis_health_check field #3896

Merged
merged 1 commit into from
Jul 19, 2018
Merged

health check: Remove the deprecated redis_health_check field #3896

merged 1 commit into from
Jul 19, 2018

Conversation

dio
Copy link
Member

@dio dio commented Jul 19, 2018

Description: This removes the deprecated redis_health_check field and only allow setting
redis health check via the custom health checker config.

Risk Level: Low
Testing: Removed tests related to the deprecated field.
Docs Changes: Updated
Release Notes: Already listed under 1.7.

Fixes #3713

Signed-off-by: Dhi Aurrahman dio@rockybars.com

Fixes #3713

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@mattklein123 mattklein123 merged commit b202f89 into envoyproxy:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants