Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_stats: fix for Google import. #3900

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

htuch
Copy link
Member

@htuch htuch commented Jul 19, 2018

Risk level: Low
Testing: OSS/Google unit/integration tests for LRS.

Signed-off-by: Harvey Tuch htuch@google.com

Risk level: Low
Testing: OSS/Google unit/integration tests for LRS.

Signed-off-by: Harvey Tuch <htuch@google.com>
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want a way to approve that is "Looks Bad But Unavoidable To Me". Stupid string mismatches :-(

Thanks for the fix. Merge away!

Copy link
Member

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for finding this!

@alyssawilk alyssawilk merged commit 982ebd2 into envoyproxy:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants