Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: use Api::SysCallResult in buffer impl #3976

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

venilnoronha
Copy link
Member

Description:
This PR replaces std::tuple with Api::SysCallResult in the buffer API and implementations. See #3819 for more information.

Signed-off-by: Venil Noronha veniln@vmware.com

Risk Level: Low
Testing: Existing tests suffice
Docs Changes: N/A
Release Notes: N/A

This commit replaces std::tuple with Api::SysCallResult in the buffer
API and implementations.

Signed-off-by: Venil Noronha <veniln@vmware.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very nice.

@mattklein123 mattklein123 merged commit f882e74 into envoyproxy:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants