Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix grammar errors #3983

Merged
merged 2 commits into from
Jul 30, 2018
Merged

docs: fix grammar errors #3983

merged 2 commits into from
Jul 30, 2018

Conversation

kakengloh
Copy link
Contributor

Fixed some grammatical errors of documentations

Signed-off-by: kkloh98 40446720+kkloh98@users.noreply.github.com

Risk Level: Low
Testing: n/a
Docs Changes: STYLE.md, CONTRIBUTING.md, SECURITY_RELEASE_PROCESS.md, REPO_LAYOUT.md
Release Notes: n/a

Fixed some grammatical errors of documentations

Signed-off-by: kkloh98 <40446720+kkloh98@users.noreply.github.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes.

CONTRIBUTING.md Outdated
@@ -90,7 +90,7 @@ maximize the chances of your PR being merged.
* We expect that once a PR is opened, it will be actively worked on until it is merged or closed.
We reserve the right to close PRs that are not making progress. This is generally defined as no
changes for 7 days. Obviously PRs that are closed due to lack of activity can be reopened later.
Closing stale PRs helps us keep on top of all of the work currently in flight.
Closing stale PRs help us to keep on top of all of the work currently in flight.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this reads better with what we previously had, or make it "helps us to"

@mattklein123 mattklein123 self-assigned this Jul 30, 2018
you're right, seems like it sounds better

Signed-off-by: kkloh98 <40446720+kkloh98@users.noreply.github.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit dc03a9a into envoyproxy:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants