Skip to content

Conversation

@markdroth
Copy link
Contributor

Commit Message: xDS: allow composite filter to configure a chain of filters
Additional Description: Adds configuration to allow composite filter to configure a chain of filters, instead of just one individual filter. Also improves some documentation related to ECDS.
Risk Level: None
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Mark D. Roth <roth@google.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #40885 was opened by markdroth.

see: more, trace.

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #40885 was opened by markdroth.

see: more, trace.

Signed-off-by: Mark D. Roth <roth@google.com>
abeyad
abeyad previously approved these changes Aug 29, 2025
Copy link
Contributor

@abeyad abeyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

@abeyad
Copy link
Contributor

abeyad commented Aug 29, 2025

/assign @adisuissa

@markdroth
Copy link
Contributor Author

Note: This PR is still marked as a draft. I'd like to gather some internal input before I mark it ready for review.

Signed-off-by: Mark D. Roth <roth@google.com>
@markdroth
Copy link
Contributor Author

/retest

Copy link
Contributor

@yanavlasov yanavlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markdroth markdroth marked this pull request as ready for review September 23, 2025 15:18
@KBaichoo
Copy link
Contributor

/wait-any

for comments to be addressed

@paul-r-gall paul-r-gall merged commit 9fb671f into envoyproxy:main Sep 30, 2025
24 of 25 checks passed
@markdroth markdroth deleted the composite_filter_chains branch October 2, 2025 15:54
yanavlasov pushed a commit that referenced this pull request Dec 22, 2025
## Description

This PR adds the implementation for `filter_chain` in the Composite
Filter. The API was added as part of
[this](#40885) PR.

This would allow multiple HTTP filters to be delegated to as a single
action, with filters executing in order for decoding and reverse order
for encoding.

---

**Commit Message:** composite: add implementation for filter_chain
**Additional Description:** Adds the implementation for `filter_chain`
in the Composite Filter.
**Risk Level:** Low
**Testing:** Added Unit + Integration Tests
**Docs Changes:** Added
**Release Notes:** Added

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
update-envoy bot added a commit to envoyproxy/data-plane-api that referenced this pull request Dec 22, 2025
## Description

This PR adds the implementation for `filter_chain` in the Composite
Filter. The API was added as part of
[this](envoyproxy/envoy#40885) PR.

This would allow multiple HTTP filters to be delegated to as a single
action, with filters executing in order for decoding and reverse order
for encoding.

---

**Commit Message:** composite: add implementation for filter_chain
**Additional Description:** Adds the implementation for `filter_chain`
in the Composite Filter.
**Risk Level:** Low
**Testing:** Added Unit + Integration Tests
**Docs Changes:** Added
**Release Notes:** Added

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

Mirrored from https://github.com/envoyproxy/envoy @ 77b78698f753d78b39863002149a76133d162d86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants