-
Notifications
You must be signed in to change notification settings - Fork 5.2k
xDS: allow composite filter to configure a chain of filters #40885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xDS: allow composite filter to configure a chain of filters #40885
Conversation
Signed-off-by: Mark D. Roth <roth@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Mark D. Roth <roth@google.com>
abeyad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm api
|
/assign @adisuissa |
|
Note: This PR is still marked as a draft. I'd like to gather some internal input before I mark it ready for review. |
Signed-off-by: Mark D. Roth <roth@google.com>
|
/retest |
yanavlasov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/wait-any for comments to be addressed |
## Description This PR adds the implementation for `filter_chain` in the Composite Filter. The API was added as part of [this](#40885) PR. This would allow multiple HTTP filters to be delegated to as a single action, with filters executing in order for decoding and reverse order for encoding. --- **Commit Message:** composite: add implementation for filter_chain **Additional Description:** Adds the implementation for `filter_chain` in the Composite Filter. **Risk Level:** Low **Testing:** Added Unit + Integration Tests **Docs Changes:** Added **Release Notes:** Added Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
## Description This PR adds the implementation for `filter_chain` in the Composite Filter. The API was added as part of [this](envoyproxy/envoy#40885) PR. This would allow multiple HTTP filters to be delegated to as a single action, with filters executing in order for decoding and reverse order for encoding. --- **Commit Message:** composite: add implementation for filter_chain **Additional Description:** Adds the implementation for `filter_chain` in the Composite Filter. **Risk Level:** Low **Testing:** Added Unit + Integration Tests **Docs Changes:** Added **Release Notes:** Added Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Mirrored from https://github.com/envoyproxy/envoy @ 77b78698f753d78b39863002149a76133d162d86
Commit Message: xDS: allow composite filter to configure a chain of filters
Additional Description: Adds configuration to allow composite filter to configure a chain of filters, instead of just one individual filter. Also improves some documentation related to ECDS.
Risk Level: None
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A