ext_authz: perform request header checks progressively #41766
Merged
+135
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: antoniovleonti <leonti@google.com>
|
/assign @tyxia |
tyxia
reviewed
Nov 2, 2025
There was a problem hiding this comment.
a high level question:
From description : This pr just makes it so that the ext authz filter checks to make sure header limits (size, count) have not been violated as the mutations are added rather than once at the end. Once this PR is merged, do we still need those validation/rejection at the end that you recently added?
If they are not needed, we should clean them up instead of having duplicated logics
|
/wait |
I've removed the original check already 😄 near the original check is a new check that only happens if the path header got updated. |
tyxia
reviewed
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: ext_authz: perform request header checks progressively
Additional Description:
No behavior change. This pr just makes it so that the ext authz filter checks to make sure header limits (size, count) have not been violated as the mutations are added rather than once at the end. This prevents this filter from hogging the worker thread's time adding a bunch of headers when it will ultimately send a local reply.
Risk Level: low
Testing: unit tests updated for each case
Docs Changes: none necessary
Release Notes: none necessary (no externally visible behavior change)