move ssl implementation dependent tests to extensions #5778
Conversation
|
Unfortunately you'll also have to do a master merge, presumably to pick up changes to the ssl_integration_test Bonus points if someone who actually does tls weighs in on the move (@PiotrSikora or @ggreenway ?) |
|
Getting in a rebase is going to take some time as upstream is now dependent on libstdc++ 6.0.22 I think because of the foreign_cc addition. RHEL7 only provides 6.0.19 :-( |
|
Oh crud. If the problem is local builds and docker isn't enough, I've found sometimes I can cherrypick-unpatch whatever change the dep for local builds, make sure I don't comit that and trust CI to verify it all works upstream Good luck whatever way you go :-) /wait |
Seems a side effect of #5218 :( |
Signed-off-by: William DeCoste <bdecoste@gmail.com>
Signed-off-by: William DeCoste <bdecoste@gmail.com>
Signed-off-by: William DeCoste <bdecoste@gmail.com>
Signed-off-by: William DeCoste <bdecoste@gmail.com>
Description: Moves integration tests that are dependent on the ssl implementation (e.g. boringssl vs openssl) to extensions. See envoyproxy#5762 Risk Level: Low Testing: All standard tests passing Docs Change: None Release Notes: None Signed-off-by: William DeCoste <bdecoste@gmail.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: William DeCoste bdecoste@gmail.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Moves integration tests that are dependent on the ssl implementation (e.g. boringssl vs openssl) to extensions. See #5762
Risk Level: Low
Testing: All standard tests passing
Docs Change: None
Release Notes: None