Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: add/test heterogenous set of StatNameStorage objects. #6504

Merged
merged 16 commits into from
Apr 22, 2019
Merged

stats: add/test heterogenous set of StatNameStorage objects. #6504

merged 16 commits into from
Apr 22, 2019

Conversation

jmarantz
Copy link
Contributor

@jmarantz jmarantz commented Apr 6, 2019 •
edited
Loading

Description: This PR breaks out one of the concepts from #6161 -- an efficient mechanism for remembering a set of StatNames to reject, to use for caching the results of the stats-matcher.
Risk Level: low -- not used yet.
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a

@jmarantz
Adds SharedStatNameStorageSet.
574f5c3 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Stop using shared_ptr for the rejected-stats set; the way it's struct…
c7fbada 
…ured, this is not necessary.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Merge branch 'master' into shared-stat-name-storage-set
16d56b8 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz jmarantz requested a review from ambuc April 6, 2019 21:54
@jmarantz
Fix comment.
40ab5d1 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Remove superfluous qualifier.
3a59d0a 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz added a commit to jmarantz/envoy that referenced this pull request Apr 7, 2019
@jmarantz
Fix tests and resync with envoyproxy#6161 and envoyproxy#6504
64d94fa 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Contributor Author

jmarantz commented Apr 8, 2019

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: asan (failed build)
🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #6504 (comment) was created by @jmarantz.

see: more, trace.

@jmarantz
Grammar tweaks.
f591058 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Merge branch 'master' into shared-stat-name-storage-set
b546542 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Merge branch 'master' into shared-stat-name-storage-set
61921f4 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
ambuc
ambuc previously approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@ambuc ambuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nits.

source/common/stats/symbol_table_impl.cc Outdated Show resolved Hide resolved
source/common/stats/symbol_table_impl.h Outdated Show resolved Hide resolved
test/common/stats/symbol_table_impl_test.cc Outdated Show resolved Hide resolved
test/common/stats/symbol_table_impl_test.cc Show resolved Hide resolved
@jmarantz
Merge branch 'master' into shared-stat-name-storage-set
facd197 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
merge master & address review comments.
2b388d6 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz jmarantz requested a review from lizan as a code owner April 19, 2019 19:57
@jmarantz
format (previously I had accidentally checked in formatting from olde…
767114d 
…r clang).

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Don't run the death-test when compiling for debug because it depends …
ede43b9 
…on a no-release assert.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Add/test swap() which is needed by envoyproxy#6161 and size() which i…
b19ef63 
…s helpful to test swap().

Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz added a commit to jmarantz/envoy that referenced this pull request Apr 21, 2019
@jmarantz
pull over test cleanup from envoyproxy#6504
a76248a 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: coverage (failed build)
🔨 rebuilding ci/circleci: tsan (failed build)
🔨 rebuilding ci/circleci: release (failed build)

🐱

Caused by: a #6504 (comment) was created by @jmarantz.

see: more, trace.

@jmarantz jmarantz mentioned this pull request Apr 21, 2019
Closed
@jmarantz
change 'inheritance' to 'containment' in the comment to reflect curre…
b588595 
…nt state.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@htuch htuch self-assigned this Apr 22, 2019
@jmarantz
Remove test for ASSERT.
dbc97af 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Merge branch 'master' into shared-stat-name-storage-set
5d29a67 
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: asan (failed build)
🔨 rebuilding ci/circleci: release (failed build)

🐱

Caused by: a #6504 (comment) was created by @jmarantz.

see: more, trace.

@jmarantz jmarantz merged commit 629bbfb into envoyproxy:master Apr 22, 2019
@jmarantz jmarantz deleted the shared-stat-name-storage-set branch April 22, 2019 19:47
mpuncel added a commit to mpuncel/envoy that referenced this pull request Apr 24, 2019
@mpuncel
Merge branch 'master' into mpuncel/hedging-impl
acb40e0 
* master:
  docs: add extension policy (envoyproxy#6678)
  ext_authz: added ability to detect partial request body data (envoyproxy#6583)
  version_history.rst: jwt_authn change missed 1.10.0 (envoyproxy#6684)
  docs: fix link in pull request template (envoyproxy#6679)
  Explicitly convert absl::string_view to std::string. (envoyproxy#6687)
  docs: improving watermark docs/comments (envoyproxy#6683)
  http filter: add CSRF filter (envoyproxy#6470)
  event: reintroduce dispatcher stats (envoyproxy#6659)
  security: postmortem for CVE-2019-990[01] (envoyproxy#6597)
  Improve build rules for (test only) library quic_port_utils. (envoyproxy#6672)
  spell check: skip unsupported extensions when called with a file (envoyproxy#6648)
  Changed TestHooks to ListenerHooks (envoyproxy#6642)
  proto: move extension-specific linking validation into extensions (envoyproxy#6657)
  stats: add/test heterogenous set of StatNameStorage objects. (envoyproxy#6504)
  docs: move xds protocol to rst (envoyproxy#6670)
  fix version history order (envoyproxy#6671)

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htuch htuch htuch approved these changes

@ambuc ambuc ambuc left review comments

@lizan lizan Awaiting requested review from lizan

Assignees

@mattklein123 mattklein123

@ambuc ambuc

@htuch htuch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmarantz @ambuc @htuch @mattklein123