Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: clarify embargo policy includes binary images. #6771

Merged
merged 4 commits into from
May 3, 2019

Conversation

htuch
Copy link
Member

@htuch htuch commented May 1, 2019

Fixes #6593

Signed-off-by: Harvey Tuch htuch@google.com

Fixes envoyproxy#6593

Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
mattklein123 previously approved these changes May 1, 2019
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one request to bold some content.

SECURITY_RELEASE_PROCESS.md Outdated Show resolved Hide resolved
Signed-off-by: Harvey Tuch <htuch@google.com>
PiotrSikora
PiotrSikora previously approved these changes May 1, 2019
@@ -253,7 +260,9 @@ Our members, Acidburn, Cereal, and ZeroCool are outstanding members and are well
known throughout the Envoy community. Especially for their contributions
in hacking the Gibson.

> 6. Accept the Embargo Policy that is outlined above.
> 6. Accept the Embargo Policy that is outlined above. You must
have a way to privately stage and validate your updates that does not violate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: tab vs spaces.

mattklein123
mattklein123 previously approved these changes May 1, 2019
tgraf
tgraf previously approved these changes May 2, 2019
Copy link

@tgraf tgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was obvious already

@htuch htuch dismissed stale reviews from tgraf, mattklein123, and PiotrSikora via 2a147f4 May 3, 2019 15:23
@htuch htuch merged commit 1c756a2 into envoyproxy:master May 3, 2019
@htuch htuch deleted the sec-policy-embargo branch May 3, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security embargo policy and binary rollouts
4 participants