dispatcher: faster runOnAllThreads #7011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The shared_ptr and the atomic<unit64_t> is duplicate in term of ref count.
Beside that this diff avoid
cb
andall_threads_complete_cb
copy at O(number of worker) scale.Theoretically the callback is passing by reference (was value copy) but I doubt anyone would rely on the previous behavior.
Signed-off-by: Yuchen Dai silentdai@gmail.com
Risk Level: LOW
Testing: existing test