Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add .java to list of linted suffixes #7210

Merged
merged 1 commit into from
Jun 8, 2019

Conversation

rebello95
Copy link
Contributor

This will allow other projects that use this script to use clang-format with .java files.

Signed-off-by: Michael Rebello mrebello@lyft.com

Testing: Done locally

This will allow other projects that use this script to use `clang-format` with `.java` files.

Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95 added a commit to envoyproxy/envoy-mobile that referenced this pull request Jun 7, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++.

2 spaces were selected for spacing to maintain parity with upstream.

Depends on:
envoyproxy/envoy#7210
envoyproxy/envoy#7211

Signed-off-by: Michael Rebello <mrebello@lyft.com>
@lizan lizan requested a review from jmarantz June 8, 2019 06:13
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit e756799 into envoyproxy:master Jun 8, 2019
@rebello95 rebello95 deleted the java-inclusion branch June 8, 2019 21:04
rebello95 added a commit to envoyproxy/envoy-mobile that referenced this pull request Jun 10, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++.

2 spaces were selected for spacing to maintain parity with upstream.

Depends on:
envoyproxy/envoy#7210
envoyproxy/envoy#7211

Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95 added a commit to envoyproxy/envoy-mobile that referenced this pull request Jun 10, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++.

2 spaces were selected for spacing to maintain parity with upstream.

Depends on:
envoyproxy/envoy#7210
envoyproxy/envoy#7211

Signed-off-by: Michael Rebello <mrebello@lyft.com>

update envoy sha

Signed-off-by: Michael Rebello <mrebello@lyft.com>

reformat after rebasing

Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95 added a commit to envoyproxy/envoy-mobile that referenced this pull request Jun 10, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++.

2 spaces were selected for spacing to maintain parity with upstream.

Depends on:
envoyproxy/envoy#7210
envoyproxy/envoy#7211

#55

Signed-off-by: Michael Rebello <mrebello@lyft.com>
jpsim pushed a commit that referenced this pull request Nov 28, 2022
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++.

2 spaces were selected for spacing to maintain parity with upstream.

Depends on:
#7210
#7211

envoyproxy/envoy-mobile#55

Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++.

2 spaces were selected for spacing to maintain parity with upstream.

Depends on:
#7210
#7211

envoyproxy/envoy-mobile#55

Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants