-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add .java to list of linted suffixes #7210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow other projects that use this script to use `clang-format` with `.java` files. Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 7, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: envoyproxy/envoy#7210 envoyproxy/envoy#7211 Signed-off-by: Michael Rebello <mrebello@lyft.com>
mattklein123
approved these changes
Jun 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 10, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: envoyproxy/envoy#7210 envoyproxy/envoy#7211 Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 10, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: envoyproxy/envoy#7210 envoyproxy/envoy#7211 Signed-off-by: Michael Rebello <mrebello@lyft.com> update envoy sha Signed-off-by: Michael Rebello <mrebello@lyft.com> reformat after rebasing Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 10, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: envoyproxy/envoy#7210 envoyproxy/envoy#7211 #55 Signed-off-by: Michael Rebello <mrebello@lyft.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: #7210 #7211 envoyproxy/envoy-mobile#55 Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: #7210 #7211 envoyproxy/envoy-mobile#55 Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow other projects that use this script to use
clang-format
with.java
files.Signed-off-by: Michael Rebello mrebello@lyft.com
Testing: Done locally