Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: changing snapshot access to be const #7677

Merged
merged 1 commit into from
Jul 22, 2019
Merged

runtime: changing snapshot access to be const #7677

merged 1 commit into from
Jul 22, 2019

Conversation

alyssawilk
Copy link
Contributor

This is a precursor to #7601 just to land the API change more quickly and make sure it sticks.

Risk Level: Low
Testing: existing unit tests
Docs Changes: n/a
Release Notes: n/a

@alyssawilk
runtime: changing snapshot access to be const
9f6a617 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
mattklein123 approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alyssawilk alyssawilk merged commit 712000a into envoyproxy:master Jul 22, 2019
mattklein123 pushed a commit that referenced this pull request Aug 13, 2019
@alyssawilk @PiotrSikora
runtime: changing snapshot access to be const (#7677) (#26)
a667908 
This is a precursor to #7601 just to land the API change more quickly and make sure it sticks.

Risk Level: Low
Testing: existing unit tests
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
LukeShu pushed a commit to datawire/envoy that referenced this pull request Aug 26, 2019
@PiotrSikora @LukeShu
runtime: changing snapshot access to be const (envoyproxy#7677) (#26)
82067af 
This is a precursor to envoyproxy#7601 just to land the API change more quickly and make sure it sticks.

Risk Level: Low
Testing: existing unit tests
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
LSChyi pushed a commit to LSChyi/envoy that referenced this pull request Sep 24, 2019
@PiotrSikora @LSChyi
runtime: changing snapshot access to be const (envoyproxy#7677) (envo…
1043a6b 
…yproxy#26)

This is a precursor to envoyproxy#7601 just to land the API change more quickly and make sure it sticks.

Risk Level: Low
Testing: existing unit tests
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: LSChyi <alan81920@gmail.com>
@alyssawilk alyssawilk deleted the const_snapshot branch December 9, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees

@lizan lizan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alyssawilk @mattklein123 @lizan