codec: add metadata_not_supported_error to HTTP/1 codec stats #7801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2019 18:54
Signed-off-by: Yang Song <yasong@google.com>
alyssawilk
reviewed
Aug 1, 2019
| @@ -140,7 +140,8 @@ CodecClientProd::CodecClientProd(Type type, Network::ClientConnectionPtr&& conne | |||
| : CodecClient(type, std::move(connection), host, dispatcher) { | |||
| switch (type) { | |||
| case Type::HTTP1: { | |||
| codec_ = std::make_unique<Http1::ClientConnectionImpl>(*connection_, *this); | |||
| codec_ = std::make_unique<Http1::ClientConnectionImpl>(*connection_, | |||
There was a problem hiding this comment.
Mind updating docs/root/configuration/http_conn_man/stats.rst ?
Each codec has the option of adding per-codec statistics. Currently only http2 has codec stats. needs updating, and a section on Http1 codec stats?
Signed-off-by: Yang Song <yasong@google.com>
mattklein123
requested changes
Aug 5, 2019
| :header: Name, Type, Description | ||
| :widths: 1, 1, 2 | ||
|
|
||
| metadata_not_supported_error, Counter, Total number of parsing metadata with http1 error |
There was a problem hiding this comment.
I don't think this description is quite right. Maybe something like "Total number of metadata frames dropped during HTTP/1 encoding" or something like that?
added 2 commits
August 6, 2019 17:35
Signed-off-by: Yang Song <yasong@google.com>
Signed-off-by: Yang Song <yasong@google.com>
|
/retest |
|
🔨 rebuilding |
|
/azp run envoy-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: introduce stats to HTTP/1 codec. Add metadata_not_supported_error.
Risk Level: Low. stats change only.
Testing: Unit test.
Docs Changes: N/A
Release Notes: