Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to GetEnvoy.io for pre-built binaries #7814

Merged
merged 4 commits into from
Aug 5, 2019

Conversation

lizan
Copy link
Member

@lizan lizan commented Aug 2, 2019

Signed-off-by: Lizan Zhou lizan@tetrate.io

Description:
Risk Level:
Testing:
Docs Changes: Docs only
Release Notes:
Fixes #5668

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from mattklein123 August 2, 2019 21:44
@mattklein123 mattklein123 self-assigned this Aug 3, 2019
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. A few comments.

/wait

Envoy does not currently provide separate pre-built binaries, but does provide Docker images. This is
the fastest way to get started using Envoy. Should you wish to use Envoy outside of a
Docker container, you will need to :ref:`build it <building>`.
Envoy provides official :ref:`pre-built Docker images <install_binaries>` and other pre-built binaries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not link directly to GetEnvoy here, but instead just rephrase and link to the other page where everything is described. Then we only have to keep one place up to date.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

docs/root/install/building.rst Outdated Show resolved Hide resolved
@@ -68,6 +68,9 @@ tests.
organizations track and deploy master in production. We encourage you to do the same so that
issues can be reported as early as possible in the development process.

There are packaged Envoy pre-built binaries in rpm, deb, and Homebrew packages are available via
`GetEnvoy.io <https://www.getenvoy.io/>`_.

We will consider producing additional binary types depending on community interest in helping with
CI, packaging, etc. Please open an `issue <https://github.com/envoyproxy/envoy/issues>`_ in GitHub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a GH link to getenvoy here and tell people to open issue against that repo for prebuilt binaries for different platforms? WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, done

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@mattklein123 mattklein123 merged commit 01bf1c3 into envoyproxy:master Aug 5, 2019
@lizan lizan deleted the docs branch August 5, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide raw Envoy binaries outside of Docker
2 participants