Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do not use SpdyString wrapper for std::string #7854

Merged
merged 1 commit into from
Aug 7, 2019
Merged

test: do not use SpdyString wrapper for std::string #7854

merged 1 commit into from
Aug 7, 2019

Conversation

bencebeky
Copy link
Contributor

Signed-off-by: Bence Béky bnc@google.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description: This is part of the effort to deprecate SpdyString and HttpString in QUICHE. QuicString has already been removed. These are/were all transparent wrappers to std::string, existing for historical reasons.

Risk Level: low

Testing: this is a change to tests

Docs Changes: n/a

Release Notes: n/a

[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Bence Béky <bnc@google.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 8b549bd into envoyproxy:master Aug 7, 2019
@bencebeky bencebeky deleted the spdystring branch August 9, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants