quiche: do not use Http2String wrapper for std::string #7856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bence Béky <bnc@google.com>
|
LGTM. Please check clang-tidy CI. Thank you. /wait |
|
/assign @danzh2010 |
Signed-off-by: Bence Béky <bnc@google.com>
…n any build target. Signed-off-by: Bence Béky <bnc@google.com>
danzh2010
reviewed
Aug 8, 2019
Signed-off-by: Bence Béky <bnc@google.com>
|
Since CircleCI/coverage failed with something that did not seem obvious to me, and this PR started to grow into two separate directions anyway, I split off half of it into #7871. This way if the CircleCI failure is real, identifying which part causes it will help me track it down, and if it's not, well then I would have had to trigger a new run anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bence Béky bnc@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: This is part of the effort to deprecate SpdyString and HttpString in QUICHE. QuicString has already been removed. These are/were all transparent wrappers to std::string, existing for historical reasons.
Risk Level: low
Testing: this is a change to tests
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]:
[Optional Deprecated:]