Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a request time metric to redis upstream #7890

Merged
merged 60 commits into from
Sep 10, 2019
Merged

Add a request time metric to redis upstream #7890

merged 60 commits into from
Sep 10, 2019

Commits on Aug 12, 2019

  1. Redo test 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    e6731a9 View commit details
    Browse the repository at this point in the history

  2. formatting 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    35b6128 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Merge branch 'master' into upstream_rq_time-metric 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    028924c View commit details
    Browse the repository at this point in the history

  2. fix ws 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    bad7ea4 View commit details
    Browse the repository at this point in the history

  3. add docs 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    a1288f1 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2019

  1. Add skeleton of stats stuff 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    44cc44d View commit details
    Browse the repository at this point in the history

  2. fix 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    723a8fd View commit details
    Browse the repository at this point in the history

  3. record command value 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    2c169e2 View commit details
    Browse the repository at this point in the history

  4. fix formatting 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    8b05c9b View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. update 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    e74161a View commit details
    Browse the repository at this point in the history

  2. update 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    8336e68 View commit details
    Browse the repository at this point in the history

  3. patched up a bit 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    359679e View commit details
    Browse the repository at this point in the history

  4. fix counter 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    506e724 View commit details
    Browse the repository at this point in the history

  5. Revert moving RedisClusterStats 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    054400b View commit details
    Browse the repository at this point in the history

  6. disable timer 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    e5770f1 View commit details
    Browse the repository at this point in the history

  7. Add config setting to enable stats 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    a110c26 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2019

  1. mend 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    4f72856 View commit details
    Browse the repository at this point in the history

  2. fix 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    7af7c7c View commit details
    Browse the repository at this point in the history

  3. try to fix 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    e06eb57 View commit details
    Browse the repository at this point in the history

  4. revert 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    04314f5 View commit details
    Browse the repository at this point in the history

  5. fix stats 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    3e8636e View commit details
    Browse the repository at this point in the history

  6. TODO: Remove prefix? 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    6c5a8ca View commit details
    Browse the repository at this point in the history

  7. improve stat prefix? 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    89c1b26 View commit details
    Browse the repository at this point in the history

  8. fix ws/format 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    b4e5944 View commit details
    Browse the repository at this point in the history

  9. fix prefixing 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    ab8047b View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2019

  1. update to get command latency 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    2441b00 View commit details
    Browse the repository at this point in the history

  2. update per henry 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    90afb6f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into upstream_rq_time-metric 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    94c0a7e View commit details
    Browse the repository at this point in the history

  4. remove uneeded millis option, make latency timer have latency suffix 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    c945058 View commit details
    Browse the repository at this point in the history

  5. lowercase commands for metrics 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    54b168f View commit details
    Browse the repository at this point in the history

  6. bit more docs 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    0f93e03 View commit details
    Browse the repository at this point in the history

  7. more docs 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    7f0001c View commit details
    Browse the repository at this point in the history

  8. fix docs 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    d04ef29 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2019

  1. address henry comments 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    4a028ae View commit details
    Browse the repository at this point in the history

  2. simplify slightly 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    b25b4d2 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. use builtins 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    becaba2 View commit details
    Browse the repository at this point in the history

  2. updated 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    f6ec8bf View commit details
    Browse the repository at this point in the history

  3. Kick CI 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    703d0fe View commit details
    Browse the repository at this point in the history

  4. Kick CI 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    fe218a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. Per jmarantz comments 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    7f70392 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2019

  1. respond to comments 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    66cb5fd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into upstream_rq_time-metric 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    3ce76bf View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Merge branch 'master' into upstream_rq_time-metric 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    7877ee7 View commit details
    Browse the repository at this point in the history

  2. Update for jmarantz new comments, part 1, basics 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    6d7c4b5 View commit details
    Browse the repository at this point in the history

  3. Update for jmarantz new comments, part 2, use stat_name_pool and stat… 

    …_name_map

Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    8d9d3d1 View commit details
    Browse the repository at this point in the history

  4. fix formatting 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    bc5a96f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. update stat_name to command 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    4e82245 View commit details
    Browse the repository at this point in the history

  2. attempt #1, move stats to config 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    abf2297 View commit details
    Browse the repository at this point in the history

  3. guard command timer on stats enabled 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    841b4a3 View commit details
    Browse the repository at this point in the history

  4. fix test override 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    2520b40 View commit details
    Browse the repository at this point in the history

  5. Update command stats ptr name and remove redundant temp 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    f76c164 View commit details
    Browse the repository at this point in the history

  6. Pass scope around, and store symboltable on command stats 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    140d9e5 View commit details
    Browse the repository at this point in the history

  7. Remove the move part 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    414e5b3 View commit details
    Browse the repository at this point in the history

  8. refactor boolean enable flag, since now a global redis stats 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    9ec13ee View commit details
    Browse the repository at this point in the history

  9. remove some unneeded moves 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    4ad0e2c View commit details
    Browse the repository at this point in the history

  10. fix clang tidy errors 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    228af54 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Merge branch 'master' into upstream_rq_time-metric 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    f2b036f View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. Add TODO comment for singleton and remove duplicate params 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    d578a4b View commit details
    Browse the repository at this point in the history

  2. fix format 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    6904da0 View commit details
    Browse the repository at this point in the history

  3. Update per mklein comments 

    Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
    @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
    FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    4fe9265 View commit details
    Browse the repository at this point in the history