Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doco update - 0 disables route timeout #7931

Merged
merged 2 commits into from
Aug 16, 2019

Conversation

nmeessen
Copy link
Contributor

Description: doco update - Calling out that it's possible to use the value 0 to disable route timeout (as it is for idle timeout).
Risk Level: Low
Testing: NA
Docs Changes: yes
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Please fix DCO and format.

/wait

Calling out that it's possible to use the value 0 to disable route timeout (as it is for idle timeout).

Signed-off-by: nmeessen <nmeessen@atlassian.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #7931 was synchronize by nmeessen.

see: more, trace.

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #7931 was synchronize by nmeessen.

see: more, trace.

Signed-off-by: nmeessen <nmeessen@atlassian.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #7931 was synchronize by nmeessen.

see: more, trace.

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit b9fe0b9 into envoyproxy:master Aug 16, 2019
@nmeessen nmeessen deleted the patch-1 branch August 16, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants