-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats: Remember recent lookups and display them in an admin endpoint #8116
Merged
jmarantz
merged 69 commits into
envoyproxy:master
from
jmarantz:remember-recent-lookups
Oct 17, 2019
Merged
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
f871f2b
initial impl.
jmarantz be02163
Add optional recent-lookups tracking to SymbolTable.
jmarantz 7f404a0
Hook up recent_lookups_ maps into SymbolTable.
jmarantz 4eeb7eb
full stack of recent-lookups admin access compiles, not tested or tried.
jmarantz c1a1a32
cleanup
jmarantz e2e384e
format
jmarantz 33c0f88
Hold fewer locks for less time.
jmarantz 8808258
Add test for SymbolTableImpl::getRecentLookups().
jmarantz 8bc22f6
simplified; admin flow almost working
jmarantz 86e9204
admin interface kind of works.
jmarantz cd83c62
collate fix.
jmarantz fd3bbbd
report the total lookup count as well.
jmarantz cfa1634
format and add admin tests.
jmarantz 49dfcb4
Merge branch 'master' into remember-recent-lookups
jmarantz e8498a2
add function doc to new functions.
jmarantz 312d389
Merge branch 'master' into remember-recent-lookups
jmarantz 491ab32
cleanup
jmarantz 45a4feb
Privatize some functions.
jmarantz 90327f7
add doc.
jmarantz 7b867b3
format
jmarantz 52793db
Merge branch 'master' into remember-recent-lookups
jmarantz 3e9e3a5
Merge branch 'master' into remember-recent-lookups
jmarantz e9662a0
Merge branch 'master' into remember-recent-lookups
jmarantz fd23fbe
Add logging and simplify impl slightly by making it untemplated and j…
jmarantz 1bf7773
added speed test.
jmarantz c949893
switch to lru
jmarantz 14f9eae
cleanup test deque behavior.
jmarantz 56b0fec
format
jmarantz 8cdf5fc
format
jmarantz 9b65b71
Merge branch 'master' into remember-recent-lookups
jmarantz b920220
Update call-sites to expect the count rather than the time.
jmarantz 2e4f122
update test to reflect we are showing counts rather than date/time.
jmarantz 82c03cd
fix golden result for admin test.
jmarantz fa447d8
Merge branch 'master' into remember-recent-lookups
jmarantz cb828f8
Merge branch 'master' into remember-recent-lookups
jmarantz 60c0673
address review comments
jmarantz 9b92a3f
clang tidy and do a better job of collating the aggregated lookup data.
jmarantz c0ad91d
remove dead local variable.
jmarantz e08c677
Hook up reset_counters to clear recent_lookups.
jmarantz b38b505
cover http2 case as well.
jmarantz e6935fc
Merge branch 'master' into remember-recent-lookups
jmarantz a8f685f
Construct StatNameSet from SymbolTable, to avoid the 'rememberSet' ha…
jmarantz 88c5dc5
Merge branch 'remember-recent-lookups-lru' into remember-recent-lookups
jmarantz c536bed
Merge branch 'master' into remember-recent-lookups
jmarantz 67b0f49
switch to lru implementation.
jmarantz 0760e00
Add more admin endpoints to control recent-lookups tracking.
jmarantz 09c948c
cleanups.
jmarantz 25cbe85
more comments.
jmarantz 514fb31
spelling.
jmarantz c9dddb4
Merge branch 'master' into remember-recent-lookups
jmarantz 5ec6fce
Cleanup LRU and fix asan error.
jmarantz 422d15d
Merge branch 'master' into remember-recent-lookups
jmarantz 049cab3
Merge branch 'master' into remember-recent-lookups
jmarantz e4ea14e
Merge branch 'master' into remember-recent-lookups
jmarantz 106d75d
Merge branch 'master' into remember-recent-lookups
jmarantz af6d5de
address remaining comments.
jmarantz 6cdf862
Merge branch 'master' into remember-recent-lookups
jmarantz 9f0b754
Merge branch 'master' into remember-recent-lookups
jmarantz 6bca221
fix builda
jmarantz 14cbbcf
Record the total recent lookups as a counter.
jmarantz d82b1df
simplify flush-stats impl for recent lookups by switching from counte…
jmarantz ff84c2c
update doc
jmarantz e8cb00c
language cleanup.
jmarantz faf1cfa
add release note.
jmarantz a70b2de
use correct method name. Awesome that we have a docs consistency chec…
jmarantz c18f184
quotes vs backquotes
jmarantz a7bb051
Merge branch 'master' into remember-recent-lookups
jmarantz f17bcdb
fix typos and add explicit option syntax.
jmarantz 298210c
un-option the reference to use-fake-symbol-table, which is not doc'd.
jmarantz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note we do need a separate mutex for this or we get deadlock detection triggered by absl when calling getDynamic().