tls: add the missing wrapper around SlotImpl allocation. #8290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to it. Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
…t callback on destruction of the ref-count shared_ptr Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
…achable-slot Signed-off-by: Xin Zhuang <stevenzzz@google.com>
…achable-slot Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
…achable-slot Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
|
/assign htuch |
|
Please add a test that covers whatever bug this is. Thank you! /wait |
…achable-slot Signed-off-by: Xin Zhuang <stevenzzz@google.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
|
/nostale |
stale
bot
removed
the
stale
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
|
/assign mattklein123 |
|
thx! |
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
…8290) Signed-off-by: Xin Zhuang <stevenzzz@google.com>
jplevyak
pushed a commit
to jplevyak/envoy
that referenced
this pull request
Oct 10, 2019
…8290) Signed-off-by: Xin Zhuang <stevenzzz@google.com>
nandu-vinodan
pushed a commit
to nandu-vinodan/envoy
that referenced
this pull request
Oct 17, 2019
…8290) Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add Wrapper around newly allocated SlotImpl.
This was missed in PR 8135. Which means newly created TLS are deallocated in the old way( destructed on owner destruction possible race, but the race window is really small, see issue #7902 )
Risk Level: Medium
Testing: N/A
Docs Changes: N/A
Release Notes: N/A