Router check tool: Add testing support for routes with runtime numerator 0 #9193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2019 15:48
Signed-off-by: Lisa Lu <lisalu@lyft.com>
Signed-off-by: Lisa Lu <lisalu@lyft.com>
|
I was wondering if we could send a runtime override setting from the tool input to override the numerator, but that will be more complex and make the input params much larger(in case we have multiple runtimes). The simpler approach LGTM. Lets add some more test cases that i mentioned in the other comment and i think we should be fine. |
Signed-off-by: Lisa Lu <lisalu@lyft.com>
jyotimahapatra
previously approved these changes
Dec 5, 2019
|
LGTM. Hum, please merge master and resolve conflict. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Prior to this change, it was not possible to test routes with runtime fraction 0/denom, as a route is only matched when the
random_valuefield is less than thedefault_valuefraction. This change sets runtime fraction numerators to 1 (arbitrary nonzero value) so that those routes can be tested. #730Risk Level: Low
Testing: added unit test in route_tests.sh to show coverage
Docs Changes: included in router_check.rst
Release Notes: included