helm: use IfNotPresent for versioned helm chart release (#3289)

Signed-off-by: zirain <zirain2009@gmail.com> Co-authored-by: Guy Daich <guy.daich@sap.com>
envoyproxy · Apr 30, 2024 · 2e0971b · 2e0971b
1 parent 8b5f031
commit 2e0971b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml
@@ -174,4 +174,4 @@ jobs:
  - name: Build and Push EG Latest Helm Chart
  if: github.event_name == 'push' && github.ref == 'refs/heads/main'
  # use `0.0.0` as the default latest version.
- run: OCI_REGISTRY=oci://docker.io/envoyproxy CHART_VERSION=v0.0.0-latest TAG=latest make helm-package helm-push
+ run: IMAGE_PULL_POLICY=Always OCI_REGISTRY=oci://docker.io/envoyproxy CHART_VERSION=v0.0.0-latest TAG=latest make helm-package helm-push
diff --git a/charts/gateway-helm/values.tmpl.yaml b/charts/gateway-helm/values.tmpl.yaml
@@ -3,7 +3,7 @@ deployment:
  image:
  repository: ${ImageRepository}
  tag: '${ImageTag}'
- imagePullPolicy: Always
+ imagePullPolicy: IfNotPresent
  imagePullSecrets: []
  resources:
  limits:

diff --git a/site/content/en/latest/install/api.md b/site/content/en/latest/install/api.md
@@ -35,7 +35,7 @@ The Helm chart for Envoy Gateway
 | createNamespace | bool | `false` | |
 | deployment.envoyGateway.image.repository | string | `"${ImageRepository}"` | |
 | deployment.envoyGateway.image.tag | string | `"${ImageTag}"` | |
-| deployment.envoyGateway.imagePullPolicy | string | `"Always"` | |
+| deployment.envoyGateway.imagePullPolicy | string | `"IfNotPresent"` | |
 | deployment.envoyGateway.imagePullSecrets | list | `[]` | |
 | deployment.envoyGateway.resources.limits.cpu | string | `"500m"` | |
 | deployment.envoyGateway.resources.limits.memory | string | `"1024Mi"` | |

diff --git a/test/helm/default.yaml b/test/helm/default.yaml
@@ -369,7 +369,7 @@ spec:
  - name: KUBERNETES_CLUSTER_DOMAIN
  value: cluster.local
  image: docker.io/envoyproxy/gateway-dev:latest
- imagePullPolicy: Always
+ imagePullPolicy: IfNotPresent
  livenessProbe:
  httpGet:
  path: /healthz
@@ -517,7 +517,7 @@ spec:
  - name: KUBERNETES_CLUSTER_DOMAIN
  value: cluster.local
  image: docker.io/envoyproxy/gateway-dev:latest
- imagePullPolicy: Always
+ imagePullPolicy: IfNotPresent
  name: envoy-gateway-certgen
  restartPolicy: Never
  securityContext: